Adding invalid hostnames is no longer fatal. #8233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will still fail if they are unpingable.
|
This disables snmp by default so users would add ping only devices. Not really sure what the difference is, from testing adding some fake devices I don't see what's changed. |
|
When I tested snmp was not disabled by default. I'll retest that. Before, if the hostname was invalid, it would not try to ping it. Now, it still shows an error, but it tries to ping/add it anyway. This was for the user with underscores in his hostnames. |
Is it not easier just to update the validation? |
|
The validation is correct in my opinion. |
|
The inspection completed: No new issues |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will still fail if they are unpingable.
DO NOT DELETE THIS TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926